Refactoring function names as no one is using it yet

This commit is contained in:
Bruno F. Fontes 2019-06-25 10:47:05 -03:00
parent 6f19522c52
commit 13fadfe9ae
Signed by: brunofontes
GPG Key ID: EE3447CE80048495
4 changed files with 23 additions and 23 deletions

View File

@ -96,13 +96,13 @@ $projectList = $memsource->project()->listProjects;
To use filters, add the API filter as parameter: To use filters, add the API filter as parameter:
```php ```php
$projectList = $memsource->project()->listProjects(['name' => 'Project X']); $projectList = $memsource->project()->list(['name' => 'Project X']);
``` ```
#### Get Project #### Get Project
```php ```php
$projectList = $memsource->project()->getProject($projectUid); $projectList = $memsource->project()->get($projectUid);
``` ```
### Jobs ### Jobs
@ -112,7 +112,7 @@ $projectList = $memsource->project()->getProject($projectUid);
Only projectUid is essencial: Only projectUid is essencial:
```php ```php
$jobs = $memsource->jobs()->listJobs($projectUid, ['count' => true, 'filename' => 'my_file.html']); $jobs = $memsource->jobs()->list($projectUid, ['count' => true, 'filename' => 'my_file.html']);
``` ```
### Bilingual Files ### Bilingual Files
@ -120,12 +120,12 @@ $jobs = $memsource->jobs()->listJobs($projectUid, ['count' => true, 'filename' =
#### Download Bilingual File #### Download Bilingual File
```php ```php
$memsource->BilingualFile()->downloadBilingualFile($projectUid, ['JobUid1', 'jobUid2'], 'download.mxliff'); $memsource->BilingualFile()->download($projectUid, ['JobUid1', 'jobUid2'], 'download.mxliff');
``` ```
#### Upload Bilingual File #### Upload Bilingual File
```php ```php
$parameters = ['format' => 'MXLF', 'saveToTransMemory' => 'None', 'setCompleted' => 'false']; $parameters = ['format' => 'MXLF', 'saveToTransMemory' => 'None', 'setCompleted' => 'false'];
$result = $api->bilingualFile()->uploadBilingualFile('upload.mxliff', $parameters); $result = $api->bilingualFile()->upload('upload.mxliff', $parameters);
``` ```

View File

@ -5,6 +5,7 @@
* @author Bruno Fontes <developer@brunofontes.net> * @author Bruno Fontes <developer@brunofontes.net>
* @link https://github.com/brunofontes * @link https://github.com/brunofontes
*/ */
namespace BrunoFontes\Memsource; namespace BrunoFontes\Memsource;
class BilingualFile extends \BrunoFontes\Memsource\BaseApi class BilingualFile extends \BrunoFontes\Memsource\BaseApi
@ -27,14 +28,14 @@ class BilingualFile extends \BrunoFontes\Memsource\BaseApi
* *
* @return array A list of the downloaded files * @return array A list of the downloaded files
*/ */
public function downloadBilingualFile(string $projectUid, array $jobUids, string $filename): array public function download(string $projectUid, array $jobUids, string $filename): array
{ {
$url = "/api2/v1/projects/{$projectUid}/jobs/bilingualFile"; $url = "/api2/v1/projects/{$projectUid}/jobs/bilingualFile";
$groupedJobUids = array_chunk($jobUids, 100); $groupedJobUids = array_chunk($jobUids, 100);
for ($i = 0; $i < count($groupedJobUids); $i++) { for ($i = 0; $i < count($groupedJobUids); $i++) {
$apiReadyArray = $this->_convertUidArrayToApiRequest($groupedJobUids[$i]); $apiReadyArray = $this->_convertUidArrayToApiRequest($groupedJobUids[$i]);
$filenames[$i] = count($groupedJobUids) > 1?"{$i}_{$filename}":$filename; $filenames[$i] = count($groupedJobUids) > 1 ? "{$i}_{$filename}" : $filename;
$filecontent = $this->fetchApi->fetch('jsonPost', $url, $apiReadyArray); $filecontent = $this->fetchApi->fetch('jsonPost', $url, $apiReadyArray);
$this->_saveIntoFile($filenames[$i], $filecontent); $this->_saveIntoFile($filenames[$i], $filecontent);
} }
@ -76,7 +77,7 @@ class BilingualFile extends \BrunoFontes\Memsource\BaseApi
* *
* @return string The http request responde from API in json format * @return string The http request responde from API in json format
*/ */
public function uploadBilingualFile(string $filename, array $params): string public function upload(string $filename, array $params): string
{ {
$urlParams = http_build_query($params); $urlParams = http_build_query($params);
$fileContent = file_get_contents($filename); $fileContent = file_get_contents($filename);

View File

@ -10,7 +10,6 @@ namespace BrunoFontes\Memsource;
class Jobs extends \BrunoFontes\Memsource\BaseApi class Jobs extends \BrunoFontes\Memsource\BaseApi
{ {
/** /**
* List jobs of a project * List jobs of a project
* The API request returns a MAX of 50 Jobs. * The API request returns a MAX of 50 Jobs.
@ -21,7 +20,7 @@ class Jobs extends \BrunoFontes\Memsource\BaseApi
* *
* @return string The JSON answer from Memsource * @return string The JSON answer from Memsource
*/ */
public function listJobs(string $projectUid, array $parameters = []): string public function list(string $projectUid, array $parameters = []): string
{ {
$url = "/api2/v2/projects/{$projectUid}/jobs"; $url = "/api2/v2/projects/{$projectUid}/jobs";
return $this->fetchApi->fetch('get', $url, $parameters); return $this->fetchApi->fetch('get', $url, $parameters);

View File

@ -19,7 +19,7 @@ class Project extends \BrunoFontes\Memsource\BaseApi
* *
* @return string The JSON answer from Memsource * @return string The JSON answer from Memsource
*/ */
public function listProjects(array $queryParams = []): string public function list(array $queryParams = []): string
{ {
return $this->fetchApi->fetch('get', $this->_url, $queryParams); return $this->fetchApi->fetch('get', $this->_url, $queryParams);
} }
@ -31,7 +31,7 @@ class Project extends \BrunoFontes\Memsource\BaseApi
* *
* @return string A json string with all project info * @return string A json string with all project info
*/ */
public function getProject(string $projectUid): string public function get(string $projectUid): string
{ {
return $this->fetchApi->fetch('get', "{$this->_url}/{$projectUid}"); return $this->fetchApi->fetch('get', "{$this->_url}/{$projectUid}");
} }