brunofontes/shareit
1
0
Fork 0
mirror of https://github.com/brunofontes/shareit.git synced 2025-02-21 22:55:04 +00:00
Code Issues Projects Releases Wiki Activity

Fixed bug causing error 500 on production

Browse Source 
Some PHP version or configuration were causing this error.

On app.blade.php of local branch, I could use "$usedItems ? :"
even if $usedItems were null, but I had to check an "isset" to the production.

On HomecController, I had to change the "object" parameter of getUsername
to "\Illuminate\Database\Eloquent\Collection" to make it work.

I took the chance to just show the number of itens in use
if it were greater than 0.
This commit is contained in:
Bruno F. Fontes 2018-10-16 20:28:59 -03:00
parent 52223676dc
commit 3d6b0dbeca
Signed by: brunofontes
GPG Key ID: EE3447CE80048495
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Http/Controllers/HomeController.php
View File

@ -55,7 +55,7 @@ class HomeController extends Controller
* *
* @return void * @return void
*/ */
public function getUsername(object $itemUsers, ?int $id) protected function getUsername(\Illuminate\Database\Eloquent\Collection $itemUsers, ?int $id)
{ {
if ($id && !isset($this->activeUsers[$id])) { if ($id && !isset($this->activeUsers[$id])) {
$this->activeUsers[$id] = $this->findName($itemUsers, $id); $this->activeUsers[$id] = $this->findName($itemUsers, $id);

2
resources/views/layouts/app.blade.php
View File

@ -8,7 +8,7 @@
<!-- CSRF Token --> <!-- CSRF Token -->
<meta name="csrf-token" content="{{ csrf_token() }}"> <meta name="csrf-token" content="{{ csrf_token() }}">
<title>{{ config('app.name', 'Laravel') }} {{ isset($usedItems) ? "(${usedItems})" : '' }}</title> <title>{{ config('app.name', 'Laravel') }} {{ isset($usedItems) && $usedItems > 0 ? "(${usedItems})" : '' }}</title>
<!-- Scripts --> <!-- Scripts -->
<script src="{{ asset('js/app.js') }}" defer></script> <script src="{{ asset('js/app.js') }}" defer></script>