brunofontes/shareit
1
0
Fork 0
mirror of https://github.com/brunofontes/shareit.git synced 2024-11-23 20:10:52 +00:00
Code Issues Projects Releases Wiki Activity

Refactoring HomeController

Browse Source 
Avoiding requests to DB
This commit is contained in:
Bruno F. Fontes 2018-09-15 00:05:24 -03:00
parent 0ff176b075
commit b40a9fa3f1
1 changed files with 25 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
app/Http/Controllers/HomeController.php
View File

@ -17,6 +17,23 @@ class HomeController extends Controller
$this->middleware('auth');
}
/**
* Get a name from a specific id in a array
*
* @param array $array The array of objects with ID and Names
* @param int $id The ID of the user
*
* @return string The username of the specified id
*/
protected function findName($array, $id)
{
foreach ($array as $object) {
if ($object->id == $id) {
return $object->name;
}
}
}
/**
* Show the application dashboard.
*
@ -24,15 +41,16 @@ class HomeController extends Controller
*/
public function index()
{
$items = User::find(\Auth::id())->items()->get();
$users = [];
$items = User::find(\Auth::id())->items()->with('users')->get();
foreach ($items as $item) {
if ($item->used_by && !isset($users[$item->used_by])) {
$users[$item->used_by] = $this->findName($item->users, $item->used_by);
}
if ($item->used_by) {
$users[$item->used_by] = User::find($item->used_by)->name;
if ($item->waiting_user_id) {
$users[$item->waiting_user_id] = User::find($item->waiting_user_id)->name;
}
if ($item->waiting_user_id && !isset($users[$item->waiting_user_id])) {
$users[$item->waiting_user_id] = $this->findName($item, $item->waiting_user_id);
}
}
return view('home', compact('items', 'users'));