brunofontes/shareit
1
0
Fork 0
mirror of https://github.com/brunofontes/shareit.git synced 2025-11-15 07:50:54 -03:00
Code Issues Projects Releases Wiki Activity

Avoiding issues and refactoring code

Browse Source 
I made the code more passive, avoiding issued at taking, returning,
storing alerts or removing alerts from an item.

Now they all check if it is with you before returning/deleting
alert etc. I am not sure if all cases are covered, but they are
better than before. I had one only issued on this on that time,
but I prefer to prioritize safety/security.

I took the opportunitie to move some code from Controllers to
the model itself, as they were changing with the DB.
This commit is contained in:
Bruno F. Fontes
2018-10-21 12:36:02 -03:00
parent 1f9da456a5
commit e22f49bc6a
4 changed files with 78 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
app/Http/Controllers/AlertController.php
View File

@@ -29,9 +29,12 @@ class AlertController extends Controller
);
return redirect('home');
}
$item->waiting_user_id = Auth::id();
$item->timestamps = false;
$item->save();
if ($item->used_by == Auth::id()) {
return redirect('home');
}
$item->storeAlert();
$loggedUser = Auth::user()->name;
$userWithItem = User::find($item->used_by);
@@ -45,10 +48,12 @@ class AlertController extends Controller
public function delete(Request $request)
{
$item = User::loggedIn()->items()->find(request('item'));
$item->waiting_user_id = null;
$item->timestamps = false;
$item->save();
if ($item->waiting_user_id != Auth::id()) {
return redirect('home');
}
$item->removeAlert();
return redirect('home');
}
}